Fix for issues with result sets that are too large for elasticsearch #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously seeker would show last page even if clicking on that page would result in a TransportError, now the behavior has changed that if the result set is larger than the max results you can browse in a sorted elasticsearch search query, (the default value for this is 10000) The last page is no longer shown. Arrows are also added in to page by 1. If the user views the last available page they are notified that there are more results they can view from the exported results.
dcwatson
reviewed
Dec 18, 2017
seeker/templates/seeker/pager.html
Outdated
| </ul> | ||
|
|
||
| {% if not show_last_page and page.number == paginator.num_pages %} |
There was a problem hiding this comment.
Feels kind of gross to put an alert() on page load in this case. Why not stick a message under the pagination links?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously seeker would show last page even if clicking on that page
would result in a TransportError, now the behavior has changed that if
the result set is larger than the max results you can browse in a sorted
elasticsearch search query, (the default value for this is 10000) The
last page is no longer shown. Arrows are also added in to page by 1. If
the user views the last available page they are notified that there are
more results they can view from the exported results.