Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change is to allow the serve port to be tweaked. #48

Conversation

npalumbo
Copy link
Contributor

For example, should we want to clone https://goclone.io and serve on port 8080:

goclone -s -P 8080 https://www.goclone.io/

For example, should we want to clone https://goclone.io and serve on port 8080:
goclone -s -P 8080 https://www.goclone.io/
cmd/clone.go Outdated Show resolved Hide resolved
cmd/clone.go Outdated Show resolved Hide resolved
pkg/server/server.go Outdated Show resolved Hide resolved
pkg/server/server.go Outdated Show resolved Hide resolved
@mesaglio
Copy link
Collaborator

This feature looks good, check the changes I suggest and pls resolve de confilcts.

@npalumbo
Copy link
Contributor Author

This feature looks good, check the changes I suggest and pls resolve de confilcts.

Thanks. I adopted the suggested changes and resolved the conflicts.

@mesaglio
Copy link
Collaborator

mesaglio commented Jun 17, 2023

LGTM
We can make a new release with this feature no? @imthaghost

@mesaglio mesaglio self-requested a review June 19, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants