Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix go tests since #251 #259

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

joshuagl
Copy link
Contributor

The changes in #251 to update the type of the annotation value in a resource descriptor was not reflected in the tests, causing them to fail. Update the tests to use the new annotation value type.


I'm not sure why the the follow-on auto-PR to update the generated code #258 did not trigger the run-go-tests workflow?

The changes in in-toto#251 to update the type of the annotation value in a
resource descriptor was not reflected in the tests, causing them to
fail. Update the tests to use the new annotation value type.

Signed-off-by: Joshua Lock <joshua.lock@uk.verizon.com>
Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Created #260 to fix the issue of the go-test workflow not running.

@TomHennen TomHennen merged commit 3714252 into in-toto:main Jun 28, 2023
@joshuagl joshuagl deleted the joshuagl/fix-go-tests branch June 29, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants