refactor: SettingsManager with TOML and better practices #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
in03
changed the title
…d-better-practices' of https://github.com/in03/proxima into feature/issue-207-Refactor-SettingsManager-with-TOML-and-better-practices
This is an empty commit. I just forgot to signal breaking changes for the semantic release Github action. BREAKING CHANGE: Config is now toml and .env in site-packages, not user home.
in03
approved these changes
Feb 17, 2023
in03
deleted the
feature/issue-207-Refactor-SettingsManager-with-TOML-and-better-practices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
Looks like TOML supports lossless parsing and easier updating.
We're currently doing a bit of gymnastics with YAML to make it work.
https://pypi.org/project/tomlkit/
Some general refactoring to improve performance and reduce edge-case errors is a good idea.
There are a few half baked features that might benefit from better configuration support.
closes #207