Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE an object should not require its dictionary value #24

Closed
volbap opened this issue May 23, 2016 · 0 comments
Closed

DELETE an object should not require its dictionary value #24

volbap opened this issue May 23, 2016 · 0 comments

Comments

@volbap
Copy link
Contributor

volbap commented May 23, 2016

Currently, the delete() call in ServerRepository is performing a DELETE to /:entity/:id and passing the JSON representation of the object as a parameter; that last part should not be needed.

Proposed solution:

  • Replace self.backend.futureForPath(path, method: .DELETE, parameters: entity.dictionaryValue)
    with self.backend.futureForPath(path, method: .DELETE, parameters: nil)

Reasoning:

  • :id is enough for identifying the object that needs to be deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant