Use normalized JSON representation internally #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Oct 17, 2022
richcarl
force-pushed
the
normalize-json
branch
from
a6f1839
to
5505416
Compare
elbrujohalcon
requested changes
Oct 17, 2022
Allows the input spec to use either atoms or binaries as map keys. E.g., if parsing an external JSON file instead of using inline Erlang maps in the handler modules, the default behaviour would be not to create atoms for keys. Similarly, all string values are normalized to binaries. This makes it easy to look up a key and check its value.
richcarl
force-pushed
the
normalize-json
branch
from
5505416
to
6c9c12b
Compare
|
And now I don't know why we can't run elvis on our code 🤦🏻 |
|
It passes |
|
Yeah… it also passes locally here… so, I'll merge the PR and accept the mystery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the input spec to use either atoms or binaries as map keys. E.g., if parsing an external JSON file instead of using inline Erlang maps in the handler modules, the default behaviour would be not to create atoms for keys. Similarly, all string values are normalized to binaries. This makes it easy to look up a key and check its value.