Overhaul #31
Merged
Overhaul #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,14 +93,14 @@ info(Msg, Req, State) -> | |||
| Result = Module:handle_info(Msg, ModuleState), | |||
| process_result(Result, Req, State). | |||
|
|
|||
| terminate(Reason, Req, State) -> | |||
| terminate(Reason, Req, State = #state{}) -> | |||
There was a problem hiding this comment.
According to Compiler:
Warning: missing specification for function terminate/3
There was a problem hiding this comment.
According to Compiler:
Warning: missing specification for function terminate/3
elbrujohalcon
force-pushed
the
elbrujohalcon.overhaul
branch
2 times, most recently
from
283fe29
to
5a8bfdf
Compare
elbrujohalcon
force-pushed
the
elbrujohalcon.overhaul
branch
from
80dae58
to
2f8ea95
Compare
| dep_sync = https://github.com/rustyio/sync.git master | ||
| dep_gun = https://github.com/extend/gun.git master | ||
| dep_meck = https://github.com/inaka/meck master | ||
| SELL_DEPS = sync |
There was a problem hiding this comment.
I think this should be SHELL_DEPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #29, #28, #27, #21, #17] It basically fixes everything