Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] removing catch #50

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[#49] removing catch #50

merged 1 commit into from
Oct 12, 2018

Conversation

ferigis
Copy link
Member

@ferigis ferigis commented Oct 12, 2018

[close #49]

@ferigis ferigis modified the milestone: wip Oct 12, 2018
@ferigis ferigis added the WIP 🚧 Work In Progress label Oct 12, 2018
@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #50 into master will increase coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   94.27%   95.08%   +0.81%     
==========================================
  Files          11       11              
  Lines         227      224       -3     
==========================================
- Hits          214      213       -1     
+ Misses         13       11       -2
Impacted Files Coverage Δ
src/sheldon_suggestions_server.erl 58.33% <100%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cfdce...cbb2790. Read the comment docs.

@ferigis ferigis removed the WIP 🚧 Work In Progress label Oct 12, 2018
@ferigis ferigis merged commit a6f2e19 into master Oct 12, 2018
@ferigis ferigis deleted the ferigis.49.removing_catch branch October 12, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing try/catch in sheldon_suggestions_server: suggestions/2
3 participants