Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow language parameter #15

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Allow language parameter #15

merged 1 commit into from
Sep 5, 2016

Conversation

tudor2004
Copy link
Contributor

For some specific calls like e.g. finAllTopCategory etsy allows an extra "language" parameter to be sent. This change enables this extra parameter.

For some specific calls like e.g. finAllTopCategory etsy allows an extra "language" parameter to be sent. This change enables this extra parameter.
@inakiabt
Copy link
Owner

inakiabt commented Sep 5, 2016

I didn't update the methods.json for a while, but looking into the latest version, I couldn't find a reference of language in findAllTopCategory definition neither on the documentation of Categories: https://www.etsy.com/developers/documentation/reference/category

I could find some definitions with an explicit language parameter as in https://www.etsy.com/developers/documentation/reference/shippingupgrade and also this "how to work with translations" doc https://www.etsy.com/developers/documentation/getting_started/translations. Is this what you're talking about? Just want to be sure if this parameter is part to some specific methods or if it's a new generic parameter.

@tudor2004
Copy link
Contributor Author

I could find some definitions with an explicit language parameter as in https://www.etsy.com/developers/documentation/reference/shippingupgrade and also this "how to work with translations" doc https://www.etsy.com/developers/documentation/getting_started/translations. Is this what you're talking about? Just want to be sure if this parameter is part to some specific methods or if it's a new generic parameter.

Yes, that is exactly what I'm talking about. The documentation isn't indeed at it's best. But as far as I understand this parameter should in fact globally accepted and it will return the result in the requested language.

So actually you don't have to update the methods.js file at all. Although it would be nice for developers to have a possibility to update the file themselves or to provide the source to an alternative json file via an config.

@inakiabt inakiabt merged commit 64514d5 into inakiabt:master Sep 5, 2016
@inakiabt
Copy link
Owner

inakiabt commented Sep 5, 2016

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants