New layout #100
Merged
New layout #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Maarten Reyniers <24940236+mrtnrey@users.noreply.github.com>
- Make use of <b-form inline> - Rename color scheme to colour scheme - Label, select box and scale now all appear on on line - Use margin left/right (x) on select field for spacing
- Add chart descriptions of @mrtnrey near charts - Rename that section the "header" Co-Authored-By: Maarten Reyniers <24940236+mrtnrey@users.noreply.github.com>
- Use container-fluid - Drop "content" class (mb-3 is used) - Make control background dark, chart background light - Put time input fields first - Control has 3 states: - lg: on the left, everything stacked except timezone/interval - sm/md: on top, with 1) date, timezone/interval and 2) site and share - xs: on top, with 1) date, 2) timezone/interval, and 3) site and share
Hi @mrtnrey, I've shortened these chart descriptions, based on input from @CeciliaNilsson709
|
@niconoe I've run Can I safely merge this into master? |
|
Thanks @peterdesmet and @mrtnrey, great work. I really like the new layout, it will just need some finishing touches here and there (I'll open issues for those). As a general rule: you can merge into master as long as 1) you're happy with the result and application behaviour 2) there's no compilation / build errors. I'll also have a look at the split label / unit issue that you had to revert so we can restore that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new layout: #97 and add description #83 (not yet footer)
BEFORE
AFTER