-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write_dwc
updates
#75
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 87.20% 84.57% -2.64%
==========================================
Files 9 9
Lines 508 512 +4
==========================================
- Hits 443 433 -10
- Misses 65 79 +14 ☔ View full report in Codecov by Sentry. |
579531a
to
8edad47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I have updated:
- NEWS.md (lots was missing from earlier versions too)
- Don't add
[subsampled representation]
inwrite_dwc()
(cfwrite_eml()
) - Update
write_eml()
documentation - Remove
package
argument inwrite_eml()
: it is not used and allows to just generate the EML from a provided DOI - Add optional parameter
generated_paragraph
to enable/disable the extra paragraph in the abstract - Have
write_eml()
return eml invisibly (cf.write_dwc()
), allowing easier tests - Reorganize tests cf. camtrapdp
dwc_occurrence_gps
>create_gps_occurrence
dwc_occurrence_ref
>create_ref_occurrence
fix #70
fix #71
fix #76