Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_dwc updates #75

Merged
merged 36 commits into from
Jul 19, 2024
Merged

write_dwc updates #75

merged 36 commits into from
Jul 19, 2024

Conversation

sannegovaert
Copy link
Member

@sannegovaert sannegovaert commented Jun 7, 2024

  • rename helper functions
    dwc_occurrence_gps > create_gps_occurrence
    dwc_occurrence_ref > create_ref_occurrence

fix #70

  • Provide no default for directory
  • Update example

fix #71

  • Write data frame invisibly
  • Write meta.xml file
    • Add tests for meta.xml file
  • Update output filename(s): to occurrence.csv
  • Simplify test helper functions

fix #76

  • update title
  • update abstract

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (ccdc3e8) to head (d6bdd9f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   87.20%   84.57%   -2.64%     
==========================================
  Files           9        9              
  Lines         508      512       +4     
==========================================
- Hits          443      433      -10     
- Misses         65       79      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sannegovaert sannegovaert changed the title write_dwc updates [draft] write_dwc updates Jun 10, 2024
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have updated:

  • NEWS.md (lots was missing from earlier versions too)
  • Don't add [subsampled representation] in write_dwc() (cf write_eml())
  • Update write_eml() documentation
  • Remove package argument in write_eml(): it is not used and allows to just generate the EML from a provided DOI
  • Add optional parameter generated_paragraph to enable/disable the extra paragraph in the abstract
  • Have write_eml() return eml invisibly (cf. write_dwc()), allowing easier tests
  • Reorganize tests cf. camtrapdp

@peterdesmet peterdesmet merged commit ce13400 into main Jul 19, 2024
8 of 9 checks passed
@peterdesmet peterdesmet deleted the write_dwc_updates branch July 19, 2024 14:18
@peterdesmet peterdesmet mentioned this pull request Sep 3, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants