-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently use gfm rather than markdown_github #285
Conversation
Could not run knit for r_database_access and r_gbif_name_matching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems fine, except in one Rmd file where some characters were escaped for an unknown reason. I suggest to revert that since it is not consistent with Pandoc's markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further, see #200 (comment). I advise to use gfm+footnotes
instead of gfm
.
Thanks for the efforts you have been doing here @peterdesmet 👍
In order not to have to re-knit tutorials, you could just update the Rmd files here, so that this is taken care of next time they are knitted. But probably that is your approach already. Caveat: some open pull requests contain new tutorials, so the changes may have to be applied there as well. |
In order to limit this problem, can you have a further look at remaining tasks in this PR @peterdesmet, so that we get this in |
@florisvdh the backslashes are removed. Do you want me to use |
I suggest to do it everywhere, since often a new tutorial will be based on another one and we better do it consistently. If you wish, I could try to do this at once, with If you'd find a way to let Hugo make the citation links that appear useful - i.e. the links which appear after adding |
The following lines caused an error in read.bib(): Error in charToDate(x) : character string is not in a standard unambiguous format @florisvdh removing the lines causes a warning (already better than an error), which also happens for 4 other entries (6 in total now): ignoring entry 'heijmans_spatial_2019' (line 106) because : A bibentry of bibtype ‘Book’ has to specify the field: publisher Can you fix this?
Also use 2 space indent
Mostly only index.Rmd containing footnotes were knitted
This reverts commit 580e6d5.
@florisvdh I have
|
And finally, I have updated the frontmatter in the open pull requests, so we don't reintroduce old frontmatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, well done 👍 . Thank you!
Description
Some
index.Rmd
files used the deprecatedvariant: markdown_github
, which results in a warning when knitting. This PR updates allindex.Rmd
files to consistently use the recommendedgfm
and 2-space indentation in yaml frontmatter:For some tutorials, this updates the
index_files/figure-markdown_github
toindex_files/gfm
. The PR has little to no effect on the website.