Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license to CC BY and include in footer #286

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Update license to CC BY and include in footer #286

merged 6 commits into from
Nov 22, 2021

Conversation

peterdesmet
Copy link
Member

@peterdesmet peterdesmet commented Nov 18, 2021 •
edited by florisvdh
Loading

This PR addresses #268:

  1. Updates repository license to CC BY
  2. Includes CC BY logo (with link) in footer of website (appears on every page)
  3. Makes some corrections to the introduction page

@peterdesmet
Make some corrections/edits on introduction page
6d89123
@peterdesmet
Remove unused logo
e3dee08
@peterdesmet
Move original logo.svg (not used by site)
88b203f
@peterdesmet
Add cc-by.svg
b4a7d1c
@peterdesmet
Include CC-BY logo in footer
777a7ba 
- Needs to be markdown
- Opted for prefix rather than suffix
- Cannot use relative "images/cc-by.svg" as link, since that will be relative from the current page
- Cannot use {baseURL} variable in link
- Therefor opted to write full site URL (rather than hotlinking to creative commons logo)
@peterdesmet
Update license to CC BY 4.0
b2b9c56 
Text taken from https://choosealicense.com/licenses/cc-by-4.0/#
@peterdesmet peterdesmet mentioned this pull request Nov 18, 2021
Closed
florisvdh
florisvdh reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@florisvdh florisvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for also updating the repo license and home page! 👍

The footer renders as follows (when serving the site available as artifact) - I suspect it was intended to show a logo:

afbeelding

@peterdesmet
Copy link
Member Author

It will become a logo once this PR is accepted. It refers to a logo at https://inbo.github.io/tutorials/images/cc-by.svg that is currently not there yet. I have to link using an absolute url because the theme does not allow to create a relative URL that works on every page.

hansvancalster
hansvancalster approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@hansvancalster hansvancalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care of this. If I understand correctly, the addition of the CC-BY prefix in the config.toml file will cause all rendered versions of *.md files to have CC-BY in the footer. That is OK.

@peterdesmet peterdesmet merged commit 26c895f into master Nov 22, 2021
@peterdesmet peterdesmet deleted the license branch November 22, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florisvdh florisvdh florisvdh left review comments

@ThierryO ThierryO ThierryO approved these changes

@hansvancalster hansvancalster hansvancalster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterdesmet @ThierryO @hansvancalster @florisvdh