Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"style" selectors added #10

Merged
merged 1 commit into from
Oct 18, 2016
Merged

"style" selectors added #10

merged 1 commit into from
Oct 18, 2016

Conversation

punund
Copy link

@punund punund commented Oct 18, 2016

I have added the ability to include style attributes for any block alongside id and class, introduced with a ; and spanning the rest of a the selector expression:

Paragraph with style {;font-color: green}
Paragraph with class and style {.class1;font-size: smaller;float: left}

This renders as

<p style="font-color: green">Paragraph with style</p>
<p style="font-size: smaller;float: left"  class="class1">Paragraph with class and style</p>

It should come after any id and class selectors. It is nearly the only thing I missed in rho.

@inca inca merged commit 35ef438 into inca:master Oct 18, 2016
@inca
Copy link
Owner

inca commented Oct 18, 2016

@punund Great stuff, thanks!

Tbh, at first I kinda felt like arguing about "semantic value" of style attribute, but then I decided to focus only on following aspects:

  1. it would make at least one human a bit happier
  2. the change is minimal, self-contained and non-breaking — in other words, nobody is upset by this change

So for me it's a clear win. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants