-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(block): headings terminate at the end of the line #15
Conversation
@inca is it possible to merge my PRs and get a new release out? |
Hello, I am sorry, I cannot accept this PR. It's not a fix, it's a breaking syntax change, which also goes against a simple rule that blocks are separated by at least one blank line. |
Hi - where is that rule defined? Try adding
into http://daringfireball.net/projects/markdown/dingus Or even into a github comment: this is a headerThis is some paragraph In Rho, you end up with something that looks like this is a header
|
The rule is right here: https://github.com/inca/rho/blob/master/SYNTAX.md#basic-concepts — and it was there since the beginning. Remember, Rho is not a "markdown on steroids". It was never advertised as such. It does not pass Markdown test spec b/c it has a stricter rule set (e.g. no variations on ul markers, structural indentations, etc.). P.S. All other PRs are merged and released. |
Oh, I see. That makes me sad. Since I have a whole load of markdown that I want to render, which does not follow that rule :-( Thanks for merging the other PRs :-) |
I am sorry for that, really. As part of the excuse, I'd like to explain why this rule was introduced in a first place. Rho emerged as an open source part behind an educational platform where lots of non-tech people were forced to drop their wysiwyg habits of authoring their courses in MS Word and start thinking in terms of a limited semantic vocabulary. When we explained the concept of "block" to them, it became apparent that all block types must follow the same rule (one blank line delimiter). Exceptions to this rule would only spoil the overall understandability, especially combined with selectors and nested constructs (like One side benefit of this rule applied to headings is that they naturally begin to stand out in plain text (a blank line after a heading makes it clearly visible and thus better perceived as a structural entity). This is something that is very difficult to achieve in Markdown just because there is no language rule to enforce that. |
65a0dbb
to
dcc9780
Compare
I accept this explanation, and I appreciate that it is good for your authors. |
No description provided.