Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Done - 15) Should we create the more generic "Protocol" as a Performed Plan and then tag using nidm:AcquisitionModality? Answer = yes.
score should go under mathematical_entity
what is a scale_item?
There are all types of scales in SIO - decimal scale, integer scale, etc. Do we need any of these?
The issue here is that both can be either a sio:'language entity' or a sio:'mathematical entity', so I have
to make the parent more general than each (except now onl:scale_item and onl:score are on the same level as both of those entities which seems not quite right since score and scale_item has an "is a" relationship with those entities. This will have to be revisited later as a separate issue.
Done 2) The definition of onl:scale is consistent with it being a sio:"language entity"
Done 6) nidm:SessionObject - I think this should be a collection. That way each scan file can be a member of the collection, but you can still retrieve the whole object if you want all of the scans from a given session. This is how it's defined by Nolan and "hasPart some AcquisitionObject".
Put nidm:SessionObject under prov:collection and get rid of the placement of prov:collection under sio:set. Remove sio:set as we don't really need it since we have prov:Collection.
Done 2) nidm:Model could go under sio:'language entity' -> sio:'description'