Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue cleanup #449

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Issue cleanup #449

merged 2 commits into from
Jan 30, 2018

Conversation

khelm
Copy link
Contributor

@khelm khelm commented Jan 30, 2018

This PR:
Done - 15) Should we create the more generic "Protocol" as a Performed Plan and then tag using nidm:AcquisitionModality? Answer = yes.

  1. score should go under mathematical_entity

  2. what is a scale_item?
    There are all types of scales in SIO - decimal scale, integer scale, etc. Do we need any of these?
    The issue here is that both can be either a sio:'language entity' or a sio:'mathematical entity', so I have
    to make the parent more general than each (except now onl:scale_item and onl:score are on the same level as both of those entities which seems not quite right since score and scale_item has an "is a" relationship with those entities. This will have to be revisited later as a separate issue.

Done 2) The definition of onl:scale is consistent with it being a sio:"language entity"

Done 6) nidm:SessionObject - I think this should be a collection. That way each scan file can be a member of the collection, but you can still retrieve the whole object if you want all of the scans from a given session. This is how it's defined by Nolan and "hasPart some AcquisitionObject".
Put nidm:SessionObject under prov:collection and get rid of the placement of prov:collection under sio:set. Remove sio:set as we don't really need it since we have prov:Collection.

Done 2) nidm:Model could go under sio:'language entity' -> sio:'description'

@khelm khelm merged commit eb8859a into incf-nidash:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant