Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defintion of "noise dependence" terms -> "error dependence" #193

Merged
merged 1 commit into from
Oct 3, 2014

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Oct 3, 2014

This issue is a companion for #176 to define the terms created to model noise dependence structures, namely:

  • nidm:hasNoiseDependence
  • nidm:NoiseDependence

( nidm:IndependentNoise, nidm:CompoundSymmetryNoise, nidm:SeriallyCorrelatedNoise, nidm:ArbitrarilyCorrelatedNoise and nidm:ExchangeableNoise discussed at STATO issue ISA-tools/stato#28).

Proposed definitions:

  • nidm:hasNoiseDependence: "Property that associates a NoiseDependence with a NoiseModel "
  • nidm:NoiseDependence: "Noise dependence model used to represent the dependence structure between observations used in the model parameters estimation."

Please let me know what you think. @nicholst: would you like to comment on those definitions?

@khelm
Copy link
Contributor

khelm commented Oct 1, 2014

How about "Model used to represent the noise-dependence structure between observations used in the full model's parameter estimation."?

@nicholst
Copy link
Contributor

nicholst commented Oct 1, 2014

I like @khelm's update, but I'd finesse it further (I'm not sure what you're referring to full model... as opposed to the restricted model when doing a hypothesis test?)

"Model for the dependence structure of the error, used as part of model estimation and inference."

I'm hinting here, too, that we should give up on trying to make statements that are more general than the mass univariate GLM.

@cmaumet
Copy link
Member Author

cmaumet commented Oct 2, 2014

Thanks @khelm and @nicholst, I like this last update, could we further remove "and inference" to get:

"Model for the dependence structure of the error, used as part of model estimation."

And maybe we could even remove "Model" (as this is an attribute of a "Noise Model")?

"Dependence structure of the error, used as part of model estimation."

@nicholst
Copy link
Contributor

nicholst commented Oct 2, 2014

+1

On Oct 2, 2014, at 4:19 AM, Camille Maumet notifications@github.com wrote:

Thanks @khelm and @nicholst, I like this last update, could we further remove "and inference" to get:

"Model for the dependence structure of the error, used as part of model estimation."


Reply to this email directly or view it on GitHub.

@khelm
Copy link
Contributor

khelm commented Oct 2, 2014

+1 from me too.

@cmaumet
Copy link
Member Author

cmaumet commented Oct 3, 2014

Now implemented as agreed:

  • nidm:ErrorDependence: "Dependence structure of the error, used as part of model estimation." [status: Ready for release].
  • nidm:hasErrorDependence: "Property that associates an ErrorDependence with an ErrorModel." [status: Ready for release].
  • nidm:ArbitrarilyCorrelatedError, nidm:CompoundSymmetricError, nidm:ExchangeableError, nidm:IndependentError, nidm:SeriallyCorrelatedError [status: To be replaced by external ontology term].

@cmaumet
Copy link
Member Author

cmaumet commented Oct 3, 2014

I think these terms are ready for release (or will be discussed elsewhere), I will now merge.

@cmaumet cmaumet changed the title Defintion of "noise dependence" terms Defintion of "noise dependence" terms -> "error dependence" Oct 3, 2014
cmaumet pushed a commit that referenced this pull request Oct 3, 2014
Defintion of "noise dependence" terms -> "error dependence"
@cmaumet cmaumet merged commit 8be9356 into incf-nidash:master Oct 3, 2014
@cmaumet cmaumet deleted the noiseDependenceTerms branch October 3, 2014 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants