verifiers/sgx-ecdsa: fix QvE report and identity verification #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
To make sgx-ecdsa-qve work correctly, sgx_tvl_verify_qve_report_and_identity() should be called in enclave. Signed-off-by: Kun Lai <me@imlk.top>
Signed-off-by: Kun Lai <me@imlk.top>
This is an enhancement to the existing verification policy. According to Intel(R) ECDSA Quote Library API document, the expiration_check_date is used to check if any collateral is expired. And if there is an expired collateral, the collateral_expiration_status will be set to a non-zero value. Signed-off-by: Kun Lai <me@imlk.top>
imlk0
force-pushed
the
fix-sgx-ecdsa-qve
branch
from
183b5b3
to
fae856a
Compare
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
sgx_tvl_verify_qve_report_and_identity()into the enclave to fix QvE report and identity verification. Additionally, it updates theqve_isvsvn_thresholdfrom 3 to 7. These changes are expected to have no impact on the sgx-ecdsa-qve verifier compiled in occlum mode. As a result, theenclave_idfield is no longer necessary and has been removed from therats_tls_conf_tstructure and all*_ctxstructures.Additionally, this PR adds a check for
collateral_expiration_statusto the sgx-ecdsa verifier, which serves as an enhancement to the existing verification policy. This change is expected to affect the sgx-ecdsa/sgx-ecdsa-qve verifier in occlum, SGX, and host mode.