Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do/Should we close inactive sockets? #37

Closed
aychtang opened this issue Oct 29, 2013 · 2 comments
Closed

Do/Should we close inactive sockets? #37

aychtang opened this issue Oct 29, 2013 · 2 comments
Labels

Comments

@aychtang
Copy link
Collaborator

Not sure if already implemented, should we close inactive sockets after a certain duration? Inactivity will be determined by no events being sent from the socket for the duration.

@incompl
Copy link
Owner

incompl commented Oct 29, 2013

I believe this is handled well by Socket.IO. The defaults outlined in
https://github.com/LearnBoost/Socket.IO/wiki/Configuring-Socket.IO lead me
to believe so, at least.

On Tue, Oct 29, 2013 at 1:23 PM, Howard Tang notifications@github.comwrote:

Not sure if already implemented, should we close inactive sockets after a
certain duration? Inactivity will be determined by no events being sent
from the socket for the duration.


Reply to this email directly or view it on GitHubhttps://github.com//issues/37
.

@aychtang
Copy link
Collaborator Author

I see, I didn't know about that. I've seen problems with socket disconnections not being handled properly before so will figure it out and add more tests for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants