[UNIT TEST] Update mockgen and create client mock #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @longquanzheng , I want to update mockgen due to deprecation and create mock for client.go |
longquanzheng
approved these changes
Nov 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 68.90% 68.63% -0.27%
==========================================
Files 29 29
Lines 1550 1556 +6
==========================================
Hits 1068 1068
- Misses 393 397 +4
- Partials 89 91 +2
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Can you fix the lint errors? |
okay, already update go mod and fix the golangci-lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR changing or adding?
This PR is created to handle unit tests for those who used this SDK NewClient and update mockgen version (https://github.com/golang/mock deprecated and moved to https://github.com/uber-go/mock)