Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need way to get root of configs #59

Closed
bmeck opened this issue Sep 6, 2012 · 4 comments
Closed

need way to get root of configs #59

bmeck opened this issue Sep 6, 2012 · 4 comments

Comments

@bmeck
Copy link
Contributor

bmeck commented Sep 6, 2012

right now conf.get(...) has no way to return the merged roots of all the stores, you can only go one level down and below.

conf.get(null) or conf.get(undefined) should most likely return the root of the config rather than complaining and throwing errors.

@stolsma
Copy link
Contributor

stolsma commented Sep 7, 2012

+1

1 similar comment
@ghost
Copy link

ghost commented Sep 7, 2012

+1

bmeck added a commit that referenced this issue Sep 7, 2012
[fix] #59 root get/set should work via null/undefined as key
@bmeck bmeck closed this as completed Sep 7, 2012
@katanacrimson
Copy link

Could this be documented please? I was wondering if this was implemented, took me a while to find this issue to know for sure. :)

@blakmatrix
Copy link

@damianb we gladly accept pull requests if you wanted to help us out there since you have it fresh in your mind :) otherwise this issue has been closed for over 6 months, a new issue will be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants