Improve performance of participant table for large number of participants #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
force-pushed
the
faster-table
branch
3 times, most recently
from
784ac85
to
5dd1aa3
Compare
tomasr8
force-pushed
the
faster-table
branch
3 times, most recently
from
46bf30c
to
0ea4da6
Compare
When there are a lot of participants (10k+) the preloader takes too long which makes the page unresponsive. We instead load the page immediately and then load the participants.
- Scrollbar height remains constant as more participants rendered via infinite scroll - Scroll location is restored when coming back from a participant page - Filteres are saved in local storage (scoped by regform id) so they are preserved when navigating to differenting pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed here: https://indico-checkin-test-2.app.cern.ch/
We currently render the whole table which gets sluggish when there's a lot of participants (10k+).
The list now uses infinite scrolling instead which makes it much more responsive.
Additionally, we normally preload all data from IndexedDB before switching to a new page (e.g. when navigating to a regform). With a large participant list, this introduces a visible lag when preloading all participants from the DB. I changed it so that the participants are loaded after the page is loaded. Note that, short participant lists will never see a difference since they are fast to load anyway.
More UX improvements based on feedback:
<ScrollRestoration />globally<ScrollRestoration />work with the participant list i.e. when coming back from a participant the scroll position is restored - not as straighforward due to the infinite scrolling and the fact that we don't use a data loader here.