This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Update to use httplug #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, looks great, I will review it shortly. |
|
@danmichaelo sorry, I just found this pending PR waiting for my review. Do you still use this library? Would you be open to step up as a maintainer? |
|
I don't remember anymore which project this was for, but it's probably still a dependency there :D I can always join you as a maintainer. It's always good to have more than one maintainer in case one is hit by a bus. |
composer.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "require": { | |||
| "php": ">=5.4", | |||
| "league/flysystem": "~1.0", | |||
| "egeloen/http-adapter": "~0.7" | |||
| "php-http/httplug": "~1.1" | |||
There was a problem hiding this comment.
It would probably be a good idea to add the virtual package as a dependency. http://docs.php-http.org/en/latest/httplug/library-developers.html#manage-dependencies
|
Yup. Added you as a maintainer. Also, had one small comment. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you think the workaround in 823ca59 also can be removed now?