Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilization of SVBONYBase::workerExposure #845

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

jctk
Copy link
Contributor

@jctk jctk commented Oct 1, 2023

svbony_base.cpp, svbony_base.h

  • SVBONYBase::grabImage disassembled and embedded in SVBONYBase::workerExposure
  • Remove unused SVBONYBase::grabImage function

svbony_helpers.h

  • Added processing in preparation for monochrome camera support (monochrome support not yet completed)
  • Changed Luma to Luma 8 bit and Luma 16 bit

- SVBONYBase::grabImage disassembled and embedded in SVBONYBase::workerExposure
- Remove unused SVBONYBase::grabImage function

svbony_helpers.h
- Added processing in preparation for monochrome camera support (monochrome support not yet completed)
- Changed Luma to Luma 8 bit and Luma 16 bit
@knro
Copy link
Collaborator

knro commented Oct 1, 2023

This was tested on which camera models? did it include video streaming as well? aborted capture? changing formats?

@jctk
Copy link
Contributor Author

jctk commented Oct 1, 2023

I did the test excluding Video Stream. I tried it a little.
I have not edited the code for Video Stream before or since.

Testing information:

Camera model:

  • SV405CC
  • SV905C

Test Variations:

  • Capture a preview and Abort capture.
  • Start Framing (Looping)
  • Sequence (Raw 8 x1 -> Raw 16 -> Luma 8 -> RGB 24
  • Simultaneous exposure. "Start Framing (looping) by SV405CC" and "Guide loop by SV905C"

Video Streaming

  • The color image is not correct before the still image is taken.
  • I assume that this is because the code after refactoring does not determine the Bayer Pattern until a still image is taken.
    I want you to Fix this. I think it is due to the fact that I asked you to fill in the Bayer Pattern in advance but you decided not to do so.

@knro
Copy link
Collaborator

knro commented Oct 1, 2023

For streaming, if you capture an image first then stream, the colors are OK?

@jctk
Copy link
Contributor Author

jctk commented Oct 1, 2023

It looked that way to me.
I streamed the entire iPad screen in red and held it up to a telescope.
Before the still image was taken it was green and after it was taken it was red.

@jctk
Copy link
Contributor Author

jctk commented Oct 1, 2023

Could you please take care of Video Streaming after you handle this PR?

@knro knro merged commit e940fd9 into indilib:master Oct 1, 2023
4 checks passed
@jctk
Copy link
Contributor Author

jctk commented Oct 1, 2023

Thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants