Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use comm.scatter for mesh distribution #308

Merged
merged 1 commit into from
May 3, 2023
Merged

Use comm.scatter for mesh distribution #308

merged 1 commit into from
May 3, 2023

Conversation

inducer
Copy link
Owner

@inducer inducer commented May 3, 2023

@inducer inducer requested a review from majosm May 3, 2023 17:24
@majosm
Copy link
Collaborator

majosm commented May 3, 2023

Hmm, I think the mirgecom tests are failing because the wall coupling was merged (and therefore mirgecom now depends on my #285 branch). I'm going to check if there's an easy way to make those changes conditional so the CI still works here in the meantime.

@inducer
Copy link
Owner Author

inducer commented May 3, 2023

No need IMO, as long as #285 goes in soon. I can just ignore the mirgecom failures for the time being. But I've put the downstream issue on the agenda for Friday, too, to at least have a discussion.

Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inducer inducer merged commit 7380319 into main May 3, 2023
@inducer inducer deleted the mesh-dist-scatter branch May 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants