-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul facial adjacency + boundary tagging #252
Conversation
not fully implemented for partition_mesh; need to be able to create multiple nonlocal adjacency groups with distinct transformations
changed from a list of maps to a list of lists to allow multiple adjacency groups per mesh group pair
splits single InterPartitionAdjacencyGroup into one per remote neighbor group for each local mesh group
7450e0b
to
c7a51cb
Compare
(Looks like I need to do a little more work on the |
77a0fb9
to
f2b6ac9
Compare
Just looking for a review of the high-level overview in the OP to check if this seems reasonable (though feel free to take a glance through the code if you're feeling particularly adventurous. 🙂) After that I'll split this up into smaller pieces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Here's an initial review up to (but not including) 5cda667 ("remove unnecessary intermediate steps in partition_mesh")
fdf3231
to
5732798
Compare
0f75406
to
bdfa920
Compare
bdfa920
to
9ddcde7
Compare
I think this is ready for another look @inducer. |
doesn't appear to be necessary; don't remember why this was here
…ary_adjacency_groups
2740f2b
to
4c62225
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/touch-ups in places after reading through the changes. Thank you for spending the time doing all this!
Co-authored-by: Thomas H. Gibson <gibsonthomas1120@hotmail.com>
Co-authored-by: Thomas H. Gibson <gibsonthomas1120@hotmail.com>
Thanks for working on this, and thanks @thomasgibson for taking a look! |
This PR:
Mesh
's facial adjacency structure to allow multiple adjacency groups for each pair of mesh element groups. In other words,List[Dict[FacialAdjacencyGroup]]
becomesList[List[FacialAdjacencyGroup]]
.FacialAdjacencyGroup
intoInteriorAdjacencyGroup
andBoundaryAdjacencyGroup
subclasses (withInterPartitionAdjacencyGroup
inheriting fromBoundaryAdjacencyGroup
).boundary_tags
/boundary_tag_bit
fromMesh
.InteriorAdjacencyGroup
/InterPartitionAdjacencyGroup
.This will almost certainly need to be split into multiple PRs, but I wanted to throw this up here first for CI + discussion.(Probably incomprehensible unless read commit-by-commit.)