Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains an ill-fated attempt to coerce the PKDO basis into pure-polynomial form for easier symbolic processing (e.g. differentiation). Ill-fated, because it's slow, doesn't work reliably (
sympy.simplify
), and incurs out-of-control round-off error at moderate orders. The honest thing is to just use a monomial basis for now. At some point, we might want to retry symbolic differentiation on the analytic form of the PKDO basis. This would require dropping the conditionals, doing the symbolic work, and reinserting them later.Until then, this PR is basically here so that others don't have to make the same mistake. There's no intention to ever merge this.
cc @xywei