Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add, test basis_func_to_polynomial #48

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

inducer
Copy link
Owner

@inducer inducer commented Dec 6, 2021

This contains an ill-fated attempt to coerce the PKDO basis into pure-polynomial form for easier symbolic processing (e.g. differentiation). Ill-fated, because it's slow, doesn't work reliably (sympy.simplify), and incurs out-of-control round-off error at moderate orders. The honest thing is to just use a monomial basis for now. At some point, we might want to retry symbolic differentiation on the analytic form of the PKDO basis. This would require dropping the conditionals, doing the symbolic work, and reinserting them later.

Until then, this PR is basically here so that others don't have to make the same mistake. There's no intention to ever merge this.

cc @xywei

@inducer inducer added the shelved label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant