Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2013.1: Add possibility to profile GenericScanKernel based kernels #10

Closed
petRUShka opened this issue Jan 29, 2013 · 5 comments
Closed

Comments

@petRUShka
Copy link

It doesn't return an Event even if I enable profiling in queue. It would be great if call method of GenericScanKernel based kernels return event if profiling is enabled in kernel.

@inducer
Copy link
Owner

inducer commented Apr 8, 2013

It can't return a single event, because a scan usually consists of three kernel calls. (fine, coarse, postprocess) What it could do at that point is return marker events before and after, but you can do that just as well from the outside. And I'm against exposing events from the internal kernel calls, because how exactly scan is implemented is just that, implementation detail.

@inducer inducer closed this as completed Apr 8, 2013
@petRUShka
Copy link
Author

As I see, you can make series of events A (fine), B (coarse), C (postprocess) where B depends on A, C depends on B and return C. Markers it a solutions but no so native as returned events.

@inducer
Copy link
Owner

inducer commented Apr 8, 2013

What's your intended use case? Out-of-order queues or profiling? For OOQ, I would agree that the scan would probably have to do what you say. For profiling, the string-of-events is mostly useless...

@petRUShka
Copy link
Author

First of all OOQ. I want to create complex scheme of kernels with complex dependencies between them. Profiling is no more that nice addition...

@inducer inducer reopened this Apr 9, 2013
@inducer
Copy link
Owner

inducer commented Apr 22, 2013

Fixed by 6046ccd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants