Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pt.Array's axes taggable types #170

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Conversation

kaushikcfd
Copy link
Collaborator

@kaushikcfd kaushikcfd commented Oct 19, 2021

This allows the axes of the arrays to be tagged.

Closes #61

@kaushikcfd kaushikcfd force-pushed the array_dot_axes branch 3 times, most recently from 331f9a9 to d85a087 Compare October 20, 2021 02:27
@kaushikcfd
Copy link
Collaborator Author

The downstream failures can be addressed by a PR in arraycontext. See inducer/arraycontext#111.

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Aside from the concerns below, this LGTM.

pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Show resolved Hide resolved
pytato/array.py Show resolved Hide resolved
pytato/loopy.py Show resolved Hide resolved
pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Oct 22, 2021

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

doc/design.rst Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Nov 24, 2021

This seems to have a few CI failures still. To avoid downstream failures, please use a snippet like the following:

https://github.com/inducer/sumpy/blob/7bb8c8c070fc8e4f7317ee9dce96f96effbc633c/.github/workflows/ci.yml#L93-L97

@kaushikcfd
Copy link
Collaborator Author

Sorry, this was lacking a rebase on top of main. Should be fixed now.

@inducer
Copy link
Owner

inducer commented Nov 25, 2021

LGTM, thanks!

@inducer inducer enabled auto-merge (rebase) November 25, 2021 00:55
@inducer inducer merged commit a9eb50a into inducer:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array axes should allow free-form tags
2 participants