-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pt.Array
's axes taggable types
#170
Conversation
331f9a9
to
d85a087
Compare
The downstream failures can be addressed by a PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Aside from the concerns below, this LGTM.
d85a087
to
6f12dad
Compare
6f12dad
to
e7586b4
Compare
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
41f748c
to
f80a1cc
Compare
959f61c
to
3385a3d
Compare
3385a3d
to
4c8938c
Compare
4c8938c
to
c2d0159
Compare
c2d0159
to
fc80f6c
Compare
fc80f6c
to
d02c306
Compare
This seems to have a few CI failures still. To avoid downstream failures, please use a snippet like the following: |
d02c306
to
51bc900
Compare
Sorry, this was lacking a rebase on top of |
LGTM, thanks! |
This allows the axes of the arrays to be tagged.
Closes #61