-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conj() and arctan2() #83
Conversation
arctan2 has some mypy errors, not sure what to do about them.
Apart from this, it seems to work, and this PR is ready for review @inducer @kaushikcfd . |
Ready for review, after some (ahem) convincing of Mypy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback, otherwise LGTM, thank you!
Also needs some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @kaushikcfd?
LGTM from my end as well. Thanks @matthiasdiener! |
No description provided.