Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conj() and arctan2() #83

Merged
merged 13 commits into from
Jun 10, 2021
Merged

add conj() and arctan2() #83

merged 13 commits into from
Jun 10, 2021

Conversation

matthiasdiener
Copy link
Collaborator

No description provided.

@matthiasdiener matthiasdiener changed the title add conj() add conj() and arctan2() Jun 8, 2021
@matthiasdiener
Copy link
Collaborator Author

arctan2 has some mypy errors, not sure what to do about them.

$ ./run-mypy.sh
pytato/array.py:1594: error: Argument 2 to "greater" has incompatible type "int"; expected "Union[Array, Union[Number, bool_, bool]]"
pytato/array.py:1594: error: Unsupported operand types for * ("int" and "Number")
pytato/array.py:1594: note: Right operand is of type "Union[Array, Union[Number, bool_, bool]]"
pytato/array.py:1594: error: Argument 2 to "where" has incompatible type "Union[Array, int, signedinteger[Any]]"; expected "Union[Array, Number, bool_, bool, None]"
pytato/array.py:1594: error: Argument 3 to "where" has incompatible type "float"; expected "Union[Array, Number, bool_, bool, None]"
Found 4 errors in 1 file (checked 13 source files)

Apart from this, it seems to work, and this PR is ready for review @inducer @kaushikcfd .

pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Outdated Show resolved Hide resolved
@matthiasdiener
Copy link
Collaborator Author

Ready for review, after some (ahem) convincing of Mypy.

Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, otherwise LGTM, thank you!

Also needs some tests.

pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Outdated Show resolved Hide resolved
pytato/array.py Show resolved Hide resolved
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kaushikcfd?

@kaushikcfd
Copy link
Collaborator

LGTM from my end as well. Thanks @matthiasdiener!

@inducer inducer enabled auto-merge (squash) June 10, 2021 00:51
@inducer inducer merged commit 243f824 into main Jun 10, 2021
@inducer inducer deleted the conj branch June 10, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants