lib/bn.js is too big

[dcousens]

With a SLOC count of over 2000 for a single file.
Perhaps its time to break out parts of it?

[indutny]

What suggestions do you have? The nice thing about this project is that you could just use lib/bn.js in a browser.

[dcousens]

I only have suggestions that compromise that capability.

[chevdor]

I would suggest to provide a minified version. That would reduce the amount a bit but I don´t see it much as an issue.

[dcousens]

@chevdor my concern isn't size in part of distribution or use in production.

My concerns were primarily in being able to review and audit a project which consists entirely of a 2000+ SLOC file.
In any other language, this could [probably] be considered a failure in the projects architecture.

[indutny]

After some consideration: I don't mind if it'll be split into the multiple files, provided that there will be a all-included js distribution, and the way to include all plugins would be simple/transparent for users.

@dcousens any suggestions how to do it?

[dcousens]

I think just a flat file structure based on the different context classes
should be enough?
On 27 Mar 2015 4:32 am, "Fedor Indutny" notifications@github.com wrote:

After some consideration: I don't mind if it'll be split into the multiple
files, provided that there will be a all-included js distribution, and the
way to include all plugins would be simple/transparent for users.

@dcousens https://github.com/dcousens any suggestions how to do it?

—
Reply to this email directly or view it on GitHub
#35 (comment).

[indutny]

Yeah, this sounds awesome. Does it sound like an interesting project to you? ;)

[dcousens]

Sure, I'll wait for you to merge #27 to save me an annoying rebase/merge effort.

[dcousens]

Its a shame you can't assign issues to people involved in the conversation.

[jprichardson]

@dcousens #27 has been merged 😜

[indutny]

This PR was hanging this for one year! :)

[dcousens]

Haha. I'll get around to this some time soon then 👍

[dcousens]

I suspect this is probably never going to be worth the time considering the relative stability of this code now.