Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: document strip() and toJSON() #105

Closed
wants to merge 1 commit into from
Closed

readme: document strip() and toJSON() #105

wants to merge 1 commit into from

Conversation

axic
Copy link
Contributor

@axic axic commented Jan 24, 2016

No description provided.

@indutny
Copy link
Owner

indutny commented Jan 24, 2016

strip() should not be documented, IMO. I can't imagine a use case for it, as all operation should strip numbers automatically.

@axic
Copy link
Contributor Author

axic commented Jan 24, 2016

Shouldn't strip be underscore prefixed (as the other internal methods) in that case?

@indutny
Copy link
Owner

indutny commented Jan 24, 2016

This is a good idea.

@axic axic mentioned this pull request Feb 1, 2016
@axic
Copy link
Contributor Author

axic commented Feb 1, 2016

@indutny created a separate PR for strip and updated this one with a new patch: to document toJSON and make the readme clearer about the other export methods

@indutny
Copy link
Owner

indutny commented Feb 9, 2016

Landed and released, thank you!

@indutny indutny closed this Feb 9, 2016
@axic axic deleted the patch/readme-document-missing branch February 9, 2016 11:24
indutny pushed a commit that referenced this pull request Nov 29, 2017
ivanshukhov pushed a commit to Kapoio/bn.js that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants