Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the codebase #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modernize the codebase #16

wants to merge 6 commits into from

Conversation

trufae
Copy link
Contributor

@trufae trufae commented Sep 1, 2023

This PR introduces the following changes:

  • Drop support for NodeJS 14
  • Rewrite into TypeScript (and fix few minor type bugs in the process)
  • It's now an ESM module, no longer a plain requirejs one
  • Rewrite the testsuite from mocha (abandoned 5 years ago) with vitest (because mocha doesn't support ESM)
  • Add a CI job to ensure nothing gets broken over time
  • Stop using the deprecated Buffer.slice API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trufae @radare @hsorbo