Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing in .check() #24

Closed
sebdeckers opened this issue Nov 6, 2017 · 4 comments
Closed

Test failing in .check() #24

sebdeckers opened this issue Nov 6, 2017 · 4 comments

Comments

@sebdeckers
Copy link
Contributor

Was trying to run the tests before implementing a change but failed out of the box.

npm t

> ocsp@1.2.0 test /Users/seb/Code/sebdeckers/ocsp
> mocha test/*-test.js



  OCSP Agent
    ✓ should connect and validate www.google.com (122ms)
    ✓ should connect and validate google.com (141ms)
    ✓ should connect and validate helloworld.letsencrypt.org (724ms)
    ✓ should connect and validate yahoo.com (908ms)
    ✓ should connect and validate nytimes.com (727ms)
    ✓ should connect and validate microsoft.com (1112ms)

  OCSP Stapling Provider
    .check()
      1) should validate google.com
    .verify()
      ✓ should verify reddit.com's stapling (377ms)
    .getOCSPURI()
      ✓ should work on cert without extensions

  OCSP Cache
    ✓ should cache ocsp response (50ms)

  OCSP Server
    ✓ should provide ocsp response to the client (46ms)


  10 passing (4s)
  1 failing

  1) OCSP Stapling Provider .check() should validate google.com:
     Uncaught Error: Failed to obtain OCSP response: 404
      at ClientRequest.onResponse (lib/ocsp/utils.js:33:9)
      at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:550:21)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)
      at Socket.socketOnData (_http_client.js:439:20)
      at addChunk (_stream_readable.js:265:12)
      at readableAddChunk (_stream_readable.js:252:11)
      at Socket.Readable.push (_stream_readable.js:209:10)
      at TCP.onread (net.js:598:20)



npm ERR! Test failed.  See above for more details.
@indutny
Copy link
Owner

indutny commented Nov 10, 2017

Should be fixed now, thank you!

@sebdeckers
Copy link
Contributor Author

sebdeckers commented Nov 10, 2017

@indutny Thanks for the fix! Unfortunately the lockfile contains references to the private NPM registry at PayPal. Could you leave out the lockfile, or generate it again using the public NPM registry?

npm ERR! network request to <EDITED> failed, reason: getaddrinfo ENOTFOUND <EDITED>

@indutny
Copy link
Owner

indutny commented Nov 10, 2017

Oh yikes. Sorry! Fixed now.

@indutny
Copy link
Owner

indutny commented Nov 10, 2017

(Edited your comment just in case 😉)

indutny added a commit that referenced this issue Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants