Revert "deep merge properties (#1877)" #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7179279.
jrson83
added a commit
to inertiajs-revamped/inertia
that referenced
this pull request
Jun 19, 2024
This was referenced Jul 4, 2024
This was referenced Jul 11, 2024
This was referenced Jul 18, 2024
This was referenced Jul 26, 2024
This was referenced Sep 4, 2024
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
This was referenced Sep 26, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1885
Resolves #1883
This PR reverts the changes in #1877, which added deep merging of properties on partial reloads. Unfortunately this has some issues, specifically in situations where props that are objects have keys removed during a partial reload.