Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to <script setup> syntax - Composition api #175

Closed
wants to merge 9 commits into from

Conversation

mchev
Copy link

@mchev mchev commented Jun 19, 2022

Here is a proposal of the refactored system for the <script setup> syntax.

As a user, I guess I would still like to have the choice between the option api and the composition api
Maybe offer two repositories, stubs or branches?

@driesvints
Copy link
Contributor

Given the age of this PR and the lack of a review, I don't think we can make it in. The size of the PR also makes it virtually impossible to do a thorough review without spending a large amount of time on it by a maintainer. I doubt we can ever make this possible, sorry. Still want to thank you for your efforts 👍

@driesvints driesvints closed this Apr 9, 2024
@mchev
Copy link
Author

mchev commented Apr 9, 2024

Given the age of this PR and the lack of a review, I don't think we can make it in. The size of the PR also makes it virtually impossible to do a thorough review without spending a large amount of time on it by a maintainer. I doubt we can ever make this possible, sorry. Still want to thank you for your efforts 👍

Thank you for the news. I understand that given the age of this PR, it would be better to start fresh with a more recent version. I would be happy to help if needed. In any case, glad to see that this repository is active again.

@mchev mchev deleted the composition-api branch April 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants