Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Compiler error removal #35

Closed
techpaul opened this issue Mar 2, 2018 · 1 comment
Closed

Additional Compiler error removal #35

techpaul opened this issue Mar 2, 2018 · 1 comment

Comments

@techpaul
Copy link
Contributor

techpaul commented Mar 2, 2018

One of the remianing compiler warning errors can be removed by conditional compiling out a function in xmc_vadc.c and xmc_vadc.h as follows

#if 0
/* API to Set the Global IClass registers*/
void XMC_VADC_GLOBAL_InputClassInit(XMC_VADC_GLOBAL_t *const global_ptr, const XMC_VADC_GLOBAL_CLASS_t config,
                                          const XMC_VADC_GROUP_CONV_t conv_type, const uint32_t set_num)

Basically the function for classifying External Mux for ADC is not used in any of the board support packages for XMC-for-Arduino.

At this stage permanently comenting out the function will have no adverse effect on your code as it is never called.

My next pull request will include this

@techpaul
Copy link
Contributor Author

techpaul commented Mar 3, 2018

Pull request was issued a few days ago

This has been merged in today at least in develop branch for those who want the fixes.

So closing this issue

@techpaul techpaul closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant