Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14191 Release cachestore-cassandra #34

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

jabolina
Copy link
Member

@jabolina jabolina commented Oct 3, 2022

https://issues.redhat.com/browse/ISPN-14191

Small change on pom to use version.infinispan pinned as the parent version. So the GH actions that update versions update the parent version instead.

Copy link
Contributor

@ryanemerson ryanemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but GH actions are much easier to read if you keep an empty line between each item in the steps array.


- name: Set release version
run: |
mvn -B versions:update-parent "-DparentVersion=[${{ github.event.inputs.version }}]" -DprocessAllModules=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a single command, you can just make this:

run: mvn ...

@ryanemerson ryanemerson merged commit e3207df into infinispan:main Oct 3, 2022
@jabolina jabolina deleted the ISPN-14191 branch October 3, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants