-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #107
base: main
Are you sure you want to change the base?
Update README.md #107
Conversation
more details for XSite example
do you mind adding the config1.yaml and config2.yaml? any new user seeing those commands may not understand where the configuration comes from. |
more generic Co-authored-by: Pedro Ruivo <pruivo@users.noreply.github.com>
@oraNod when you have time, can you take a look? |
more generic Co-authored-by: Pedro Ruivo <pruivo@users.noreply.github.com>
good Idea, I'll add it to the readme, too |
added config1 + 2
clarify description Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Pedro Ruivo <pruivo@users.noreply.github.com>
@pruivo and @ryanemerson I've been thinking about this a little more and wonder if this readme is the right place for these xsite-details? This feels a little bit like the simple-tutorial that already uses the image. I don't wish to discourage any contributions but wonder if there is potential to bloat the readme, duplicate content, add maintenance overhead? Basically is this content being added to the right place? |
First of all, thanks for the contribution @shivan much appreciated. @oraNod I agree that this feels more like a tutorial of a specific use-case. The original idea of the readme was to just detail the images capabilities and config options. I do think this content is of value though, so maybe we should create a |
Well, the cache creating can be removed because it isn't specific to the image (create a reference to the Infinispan docs?) |
more details for XSite example
fixes #106