Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Switch to using react-native-dotenv #197

Merged
merged 7 commits into from
Aug 2, 2019
Merged

Conversation

jamonholmgren
Copy link
Member

@jamonholmgren jamonholmgren commented Jun 1, 2019

Moves to react-native-dotenv rather than what we were using before.

Fixes #194.

@jamonholmgren jamonholmgren marked this pull request as ready for review June 2, 2019 03:25
Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added .babelrc back in after the 3.0 release because using package.json was causing this issue: #145.

@jamonholmgren
Copy link
Member Author

Added back in the .babelrc. If this issue goes away in the future, I'd love to move it back into the package.json.

@jamonholmgren
Copy link
Member Author

Going to wait for #227 to be merged before merging this one. I'll have a few conflicts to fix but not many.

@jamonholmgren jamonholmgren changed the title Docs: improve onboarding experience Switch to using react-native-dotenv Aug 2, 2019
@jamonholmgren jamonholmgren merged commit 3af9874 into master Aug 2, 2019
@jamonholmgren jamonholmgren deleted the docs/update-onboarding branch August 2, 2019 02:08
infinitered-circleci pushed a commit that referenced this pull request Aug 2, 2019
# [4.6.0](v4.5.0...v4.6.0) (2019-08-02)

### Features

* **deps:** Upgrade to react-native 0.60.4 and bump most other dependencies ([#227](#227) by [@bryanstearns](https://github.com/bryanstearns)) ([e8b5d9e](e8b5d9e))
* **env:** Switch to using react-native-dotenv ([#197](#197) by [@jamonholmgren](https://github.com/jamonholmgren)) ([3af9874](3af9874))
@infinitered-circleci
Copy link

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env info is not up to date.
5 participants