fix: Fix Compile Errors #213
Conversation
boilerplate/tsconfig.json
Outdated
| @@ -11,7 +11,8 @@ | |||
| "noImplicitThis": true, | |||
| "noUnusedLocals": true, | |||
| "sourceMap": true, | |||
| "target": "es2015" | |||
| "target": "es2015", | |||
| "lib": ["es6"] | |||
There was a problem hiding this comment.
I think we should probably just make this "lib": ["esNext"]. I know we have a bunch of projects that use newer features.
There was a problem hiding this comment.
@kevinvangelder Want to update this?
There was a problem hiding this comment.
@bryanstearns Do you think this is a good idea, or should we hold off on this?
There was a problem hiding this comment.
I'm not an expert in cutting edge Javascript but since I play one on TV, my preference is to avoid using esNext in real projects since its definition changes over time, and "proposed" features' definitions sometimes change before they're accepted.
I'd have no problem changing to the latest specific version, like "lib": ["es2018"], though; this gives us const { x, ...rest} = y spreading in assignments, which is the latest future-y thing I've needed recently.
There was a problem hiding this comment.
FYI: react-native init foo --template=typescript sets target to "esnext" and lib to ["es6"]. This confuses me - it seems to mean "let me use es6 / es2015 syntax in my code, but assume that the javascript engine supports the latest proposed features" ¯\(ツ)/¯
There was a problem hiding this comment.
@jamonholmgren I've tested this both as-is and with this change, and both are good!
| "lib": ["es6"] | |
| "lib": ["es2018"] |
|
Going to wait for #227 to be merged before merging this one. |
## [4.6.1](v4.6.0...v4.6.1) (2019-08-14) ### Bug Fixes * 📦Bump detox to 14.0.1 ([#233](#233) by [@rdewolff](https://github.com/rdewolff)) ([19036df](19036df)) * Addresses storybook dependency and pod install issues ([#238](#238) by [@bryanstearns](https://github.com/bryanstearns)) ([d88d60e](d88d60e)) * Update to use es6 lib in tsconfig ([#213](#213) by [@kevinvangelder](https://github.com/kevinvangelder)) ([b530eee](b530eee))
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #154