This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Prettier-ize & lint Bowser and generated projects #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same settings as generated projects Also lint js files at root
Don't bother prettying ignite.json: Ignite (indirectly thru gluegun) uses fs-jetback to write this file; there's no easy way to tell it to make sure to write a newline on the end, and this file is written after Bowser finishes so we can't fix it. Rather than leave this as a difference that'll be created the first time someone runs `yarn format` in the new project, we'll ignore it.
bryanstearns
changed the title
kevinvangelder
approved these changes
Jun 28, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
Jul 4, 2019
# [4.5.0](v4.4.5...v4.5.0) (2019-07-04) ### Features * Prettier-ize & lint Bowser and generated projects ([#214](#214)) ([381a900](381a900))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a new project and found that out-of-the-box it had lint complaints and formatting that prettier was unhappy with. So: