This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Fix storybook dependency problem (and a couple of others) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanstearns
changed the title
This was referenced Aug 13, 2019
ryanlntn
approved these changes
Aug 13, 2019
jamonholmgren
approved these changes
Aug 14, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 14, 2019
## [4.6.1](v4.6.0...v4.6.1) (2019-08-14) ### Bug Fixes * 📦Bump detox to 14.0.1 ([#233](#233) by [@rdewolff](https://github.com/rdewolff)) ([19036df](19036df)) * Addresses storybook dependency and pod install issues ([#238](#238) by [@bryanstearns](https://github.com/bryanstearns)) ([d88d60e](d88d60e)) * Update to use es6 lib in tsconfig ([#213](#213) by [@kevinvangelder](https://github.com/kevinvangelder)) ([b530eee](b530eee))
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi. I think this was supposed to fix my issue, but I still a pod-related error with 4.6.1 & 4.6.2. Please see issue #243 (PS. I made the same comment earlier against the actual change-set, but thought I should add the comment in the actual issue, instead. So, added it here. Sorry, I'm new at this.) |
|
We're working on a fix @wistler ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to generate a new project and run tests, they fail with
Cannot find module 'emotion-theming' from 'index.js'which seems to be this Storybook problem -- it seems like a couple of their dependencies aren't being hoisted properly, and seems to be fixed by explicitly adding them to the main project... which I've done.Also, fixed #231 - don't run
pod installunless thepodexecutable is available. Also, I added a Solidarity rule to check for that executable on Mac only.Also also, fixed #199 (at least, the part I think is actionable) -- the generated-app test now explicitly verifies that
yarn compiledoesn't complain (along with the existing format & lint checks).