This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Fix navigation generator #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
approved these changes
Aug 16, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 17, 2019
## [4.6.2](v4.6.1...v4.6.2) (2019-08-17) ### Bug Fixes * **generators:** Fix navigation generator ([#240](#240) by [@bryanstearns](https://github.com/bryanstearns)) ([3dc9ba5](3dc9ba5))
|
🎉 This PR is included in version 4.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignite g navigation Testfailed with a type error:read-pkg-updoesn't return the package; it returns an object with {package, path}. (I did bump theread-pkg-upversion from 5.0.0 to 6.0.0 recently, but it's not apparent from the limited release notes that the result type changed... so maybe this has been broken for a while.)Fixes #237.
Also added a simple test for the navigation generator. To drive the generator from the test, the generator now checks for options before asking its questions. Like the other generator tests, this one isn't exhaustive, but at least checks that the basic flow works, which'll hopefully prevent problems like this in the future.