This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Update to React Native 0.61 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
requested review from
bryanstearns,
kevinvangelder and
robinheinze
jamonholmgren
commented
Oct 7, 2019
| @@ -20,7 +20,6 @@ DerivedData | |||
| *.hmap | |||
| *.ipa | |||
| *.xcuserstate | |||
| project.xcworkspace | |||
There was a problem hiding this comment.
They removed this line in the new version.
| # in the default .gitignore generated by React-Native CLI | ||
|
|
||
| # VS Code | ||
| .vscode |
There was a problem hiding this comment.
This is our only customization of this file. Perhaps we should let RN generate it and then just append.
| @@ -46,32 +46,28 @@ | |||
| "validate.js": "0.13.1" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "^7.5.5", | |||
| "@babel/runtime": "^7.5.5", | |||
There was a problem hiding this comment.
react-native init already includes these deps, so we don't have to.
| "@types/react-navigation": "3.0.7", | ||
| "@types/react-test-renderer": "16.8.3", | ||
| "@typescript-eslint/eslint-plugin": "^1.1.0", | ||
| "@typescript-eslint/parser": "^1.1.0", | ||
| <% if (props.includeDetox) { -%> | ||
| "detox": "^14.0.1", | ||
| <% } -%> | ||
| "eslint": "^6.1.0", |
There was a problem hiding this comment.
Already in the generated package.json.
|
Fixed (hopefully) the CI failures. |
robinheinze
approved these changes
Oct 7, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 7, 2019
## [4.7.4](v4.7.3...v4.7.4) (2019-10-07) ### Bug Fixes * **boilerplate:** Update to React Native 0.61 ([#263](#263) by [@jamonholmgren](https://github.com/jamonholmgren)) ([3f7894c](3f7894c))
|
🎉 This PR is included in version 4.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward upgrade!
Here's the upgrade helper link: https://react-native-community.github.io/upgrade-helper/?from=0.60.5&to=0.61.2