fix(networking): Protect against empty timer (#1039 by @odjhey)

odjhey · web-flow · commit 4406ae941dfc · 2022-05-11T22:09:44.000-07:00
diff --git a/src/plugins/networking.ts b/src/plugins/networking.ts
@@ -76,7 +76,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti
 
     // fetch and clear the request data from the cache
     const rid = xhr._trackingName
-    const cachedRequest = requestCache[rid] || {}
+    const cachedRequest = requestCache[rid] || { xhr }
     requestCache[rid] = null
 
     // assemble the request object
@@ -112,7 +112,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti
       }
 
       // send this off to Reactotron
-      ;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer()) // TODO: Fix
+      ;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer ? stopTimer() : null) // TODO: Fix
     }
 
     // can we use the real response?

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti`
`76`	`76`
`77`	`77`	`// fetch and clear the request data from the cache`
`78`	`78`	`const rid = xhr._trackingName`
`79`		`- const cachedRequest = requestCache[rid] \|\| {}`
	`79`	`+ const cachedRequest = requestCache[rid] \|\| { xhr }`
`80`	`80`	`requestCache[rid] = null`
`81`	`81`
`82`	`82`	`// assemble the request object`
`@@ -112,7 +112,7 @@ export default <ReactotronSubtype = ReactotronCore>(pluginConfig: NetworkingOpti`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`// send this off to Reactotron`
`115`		`- ;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer()) // TODO: Fix`
	`115`	`+ ;(reactotron as any).apiResponse(tronRequest, tronResponse, stopTimer ? stopTimer() : null) // TODO: Fix`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`// can we use the real response?`