Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename State #413

Merged
merged 6 commits into from
Apr 29, 2017
Merged

Rename State #413

merged 6 commits into from
Apr 29, 2017

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Apr 22, 2017

Live from Amsterdam, almost functioning PR needs lil help
snapshots

@GantMan
Copy link
Member Author

GantMan commented Apr 22, 2017

Just need to know how to mobx that data back to where it needs to go. Maybe a quick screen sesh would do it. I kinda see what we do, but not too sure.

@skellock
Copy link
Contributor

Sweet. Now something like this but for renaming?

@GantMan
Copy link
Member Author

GantMan commented Apr 22, 2017

I'm a little lost on the this.server.commands['state.backup.response'].remove(state) since I can't seem to figure out what commands are. I could pass the backup around and then modify it in the final event, but that seems dirty. I'm not sure what the best practice should be.

@skellock
Copy link
Contributor

The commands come from reactotron-core-server. Its a map of command names to the latest 100 messages for each.

Not sure what you're getting at about best practices. Is there better ways to build this? Absolutely.

This works pretty good. Has for a year. I'm all ears if you're thinking of refactoring.

@skellock
Copy link
Contributor

renamesnapshot

@skellock skellock merged commit 833241a into master Apr 29, 2017
@skellock skellock deleted the rename_state branch April 29, 2017 05:56
@skellock skellock changed the title [Needs Help] - Rename state Rename State Apr 29, 2017
@GantMan
Copy link
Member Author

GantMan commented Apr 29, 2017

lookin good

@skellock skellock added this to the 1.11 milestone May 23, 2017
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants