Fix jpegOrientation for camera sensors not at 90 degrees #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3. :) |
|
Code looks good, I'm glad it fixes your problem. I will have to test on usual suspects just to avoid any regressions. Turning your phone does not break the layout and camera preview? Also, I'll probably add Exif information in save process to this PR, I believe Nexus 5X did not write anything when we tested. |
|
Turning works great for me. Check the exif info first, this might even add it - I'm not sure. |
| deviceOrientation = (deviceOrientation + 45) / 90 * 90; | ||
|
|
||
| // Reverse device orientation for front-facing cameras | ||
| boolean facingFront = cameraCharacteristics.get(CameraCharacteristics.LENS_FACING) == CameraCharacteristics.LENS_FACING_FRONT; |
There was a problem hiding this comment.
Awesome that you think ahead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified with turning my phone in all directions and taking pictures!
Also works correctly for the front camera on my Nexus 5X.
Please test on your Nexus 6, it has a 90 degree mounted camera in the back and a 270 degree camera mounted in the front (for the 5X it's the other way around).