-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locker documentation #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private helpere netreba trenutno dikumentirati posto su sada sakriveni od usera.
Provjeri samo za property canUseAuthenticationWithBiometrics
ako ima potrebe da nam on vraca neki enum value. Iz naminga bih rekao da se ocekuje neka bool vrijednost, a i ima mi smisla da se ovdje vrati samo bool.
/** | ||
The biometrics type that the device supports (None, TouchID, FaceID). | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
The biometrics type that the device supports
Available states: None, TouchID, FaceID
*/
|
||
/** | ||
The biometrics type that the device supports which is enabled in the device settings. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this could be just a BOOL value?
In conbination with deviceSupportsAuthenticationWithBiometrics
you can check if user can use for example FaceID 🤔
What do you think?
Nisam sigurna sto je bolje, enum ili bool. Ne znam, koliko ima smisla, ali mozda bi mogli imati i dvije metode, jedna koja vraca enum, druga bool. Nisam pametna 🤔 |
Ostavimo za sada onda ovako, pa ako ce biti potrebe dodamo jos jedan property i ovaj stavimo kao deprecated :) Azuriras samo Readme s novim nazivima metoda i dodaj Swift verzije koda u doc, pa mozemo mergati onda ovaj PR |
Napravila sam dokumentaciju samo za Locker.h file.
U pravilu bi ljudi trebali koristiti samo Locker klasu, a LockerHelpers je klasa vise interna, pa joj nije toliko potrebna dokumentacija.
Kad nadem vremena, napravim mozda i na njoj.
Zasad sam samo ovu nabrzaka.
I da, trebat ce i README updateati, radi novih imena metoda. :( 🔫