Remove protected access modifier from request method in CollectionService

[danipavic]

Relevant version

• 0.x
• 1.x
• 2.x

Relevant libraries

• utils
• core
• network
• jsonapi
• jsonapi-angular

Breaking change

No

Description

Currently request method in CollectionService has protected access modifier. This isn't causing any issues on its own but makes writing hacky unit tests for model services that use request.

Example of a real method in a service that extends CollectionService:

@Injectable({
	providedIn: 'root',
})
export class ExampleService extends CollectionService<ExampleModel, AppCollection> {
	constructor(@Inject(APP_COLLECTION) protected override readonly collection: AppCollection) {
		super(collection);
	}

	public exampleMethod(): Observable<Response<ExampleModel>> {
		return this.request(`quizzes/${id}/finish`, 'PATCH');
	}
}

Since the request is protected it is not possible to spyOn without casting and the tests look like this:

	it('should finish', (done: DoneFn) => {
		const requestSpy = spyOn(service, 'request' as any).and.returnValue(of({}));
	
		service.exampleMethod().subscribe(() => {
			expect(requestSpy).toHaveBeenCalledOnceWith(`quizzes/${id}/finish`, 'PATCH');
			done();
		});
	});

I would like to avoid as any, I can't think of any reason why this method would be protected as all other methods are public, and also the request method in IJsonapiCollection interface is public as well. TLDR: We should remove the access modifier on request method.